mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jojy Varghese" <j...@mesosphere.io>
Subject Re: Review Request 39518: Changed write api.
Date Fri, 23 Oct 2015 17:21:32 GMT


> On Oct. 23, 2015, 7:59 a.m., Benjamin Bannier wrote:
> > src/slave/containerizer/provisioner/docker/registry_client.cpp, line 642
> > <https://reviews.apache.org/r/39518/diff/1/?file=1102455#file1102455line642>
> >
> >     Wouldn't this potentially cause data loss if the called `write` function cannot
dump everything in the `fd`?

Good point. Didnt realize that write could return unfinished. Addressed in https://reviews.apache.org/r/39340/


- Jojy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39518/#review103739
-----------------------------------------------------------


On Oct. 21, 2015, 6:13 p.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39518/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2015, 6:13 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-3773
>     https://issues.apache.org/jira/browse/MESOS-3773
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See MESOS-3773.
> 
> Change:
> io::write(fd, string) has been having issues with junk being written to the
> file. Using io::write(fd, void*, size_t) does not have this issue.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/provisioner/docker/registry_client.cpp 24aa95c5800ff4dfb37465b71421b014b5dd5998

> 
> Diff: https://reviews.apache.org/r/39518/diff/
> 
> 
> Testing
> -------
> 
> Make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message