mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guangya Liu" <gyliu...@gmail.com>
Subject Re: Review Request 39548: SchedulerTest.Suppress is flaky
Date Fri, 23 Oct 2015 05:25:42 GMT


> On 十月 23, 2015, 3:53 a.m., Anand Mazumdar wrote:
> > src/tests/scheduler_tests.cpp, lines 999-1008
> > <https://reviews.apache.org/r/39548/diff/2/?file=1103771#file1103771line999>
> >
> >     Wondering, why did you change order here i.e. move this piece of code up ? 
> >     
> >     Now, with using `FUTURE_DISPATCH` you can gurrantee that `Suppress` would be
completed before the `Clock` is advanced. Am I missing something ?

I think that the order of SUPPRESS and DECLINEN is not that important as long as we can make
sure the offer will be send after decline filter time out. So here it is OK to adjust and
keep the order.


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39548/#review103710
-----------------------------------------------------------


On 十月 23, 2015, 2:32 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39548/
> -----------------------------------------------------------
> 
> (Updated 十月 23, 2015, 2:32 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3733
>     https://issues.apache.org/jira/browse/MESOS-3733
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Root Cause: The reason is that the DECLINE call set filter as 1hr,
> the Clock::advance set as 100m. A race condition is that both DECLINE
> and SUPPRESS started up in different threads and the call Clock::advance
> may be called before SUPPRESS finished. The clock advanced for 100m which
> is greater than 1hr, this caused the allocator start to allocate resource
> again and ASSERT_TRUE(event.isPending()) will be failed.
> 
> Solution: Call SUPPRESS first, and make sure SUPPRESS call ready before
> call DECLINE.
> 
> 
> Diffs
> -----
> 
>   src/tests/scheduler_tests.cpp 7946cb48d62f4ed6d0fdbc771746518e31921f97 
> 
> Diff: https://reviews.apache.org/r/39548/diff/
> 
> 
> Testing
> -------
> 
> Platform: Ubuntu 14.04
> make 
> make check
> bin/mesos-tests.sh --gtest_filter="ContentType/SchedulerTest.Suppress/*"  --gtest_repeat=-1
--gtest_break_on_failure
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message