mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joerg Schad" <jo...@mesosphere.io>
Subject Re: Review Request 39285: Added Quota Request Validation.
Date Thu, 22 Oct 2015 15:26:22 GMT


> On Oct. 22, 2015, 10:57 a.m., Alexander Rukletsov wrote:
> > src/master/quota_handler.cpp, lines 64-66
> > <https://reviews.apache.org/r/39285/diff/4/?file=1103067#file1103067line64>
> >
> >     This is an API change which contradicts the API described in the design doc
and differs from, for example, dynamic reservations. Mind elaborating why you have opted for
this change?

No strong preference, will switch back.


- Joerg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39285/#review103555
-----------------------------------------------------------


On Oct. 22, 2015, 4:38 a.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39285/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2015, 4:38 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3199
>     https://issues.apache.org/jira/browse/MESOS-3199
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added Quota Request Validation.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39285/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message