mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Artem Harutyunyan" <ar...@mesosphere.io>
Subject Re: Review Request 39194: Added documentation and scripts for building mesos.apache.org website locally in a Docker container.
Date Wed, 21 Oct 2015 04:02:33 GMT


> On Oct. 20, 2015, 3:02 p.m., Adam B wrote:
> > support/site-docker/Dockerfile, line 3
> > <https://reviews.apache.org/r/39194/diff/4/?file=1102098#file1102098line3>
> >
> >     Where'd this version number come from? What does it mean? When do we increment
it?

I removed the comment line.


> On Oct. 20, 2015, 3:02 p.m., Adam B wrote:
> > support/site-docker/Dockerfile, line 1
> > <https://reviews.apache.org/r/39194/diff/4/?file=1102098#file1102098line1>
> >
> >     Maybe we should use the official Apache license header?

Removed the comment. If you really feel it's necessary I can add the Apache license header.
Please let me know.


- Artem


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39194/#review103315
-----------------------------------------------------------


On Oct. 20, 2015, 1:51 p.m., Artem Harutyunyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39194/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2015, 1:51 p.m.)
> 
> 
> Review request for mesos, Adam B and Dave Lester.
> 
> 
> Bugs: MESOS-3694
>     https://issues.apache.org/jira/browse/MESOS-3694
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   support/site-docker/Dockerfile PRE-CREATION 
>   support/site-docker/README.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39194/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message