mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Greg Mann" <g...@mesosphere.io>
Subject Re: Review Request 39018: Added JSON parsing for Resources.
Date Tue, 20 Oct 2015 05:01:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39018/
-----------------------------------------------------------

(Updated Oct. 20, 2015, 5:01 a.m.)


Review request for mesos, Adam B, Alexander Rukletsov, Jie Yu, and Michael Park.


Changes
-------

Formatting, inserted static keyword, refactored `validateCommandLineResources`, removed `conflictingTypes`.


Bugs: MESOS-2467
    https://issues.apache.org/jira/browse/MESOS-2467


Repository: mesos


Description
-------

This includes code changes necessary for JSON parsing of Resources. Documentation changes
will be posted soon in another review (https://reviews.apache.org/r/39102/).


Diffs (updated)
-----

  include/mesos/resources.hpp 6c3a065945eb56dc88df9c977e5ca11d4cbcbf61 
  include/mesos/v1/resources.hpp fe8925ac851b74d1b37919f00afc7ed816f47ea5 
  src/common/resources.cpp 601388c35a1bff37c58e753d1870d53b8d0af2d1 
  src/tests/resources_tests.cpp 6584fc6c39e6ffe9f8085576677dcc669f127697 
  src/v1/resources.cpp dc868903472f8f3a1ddc56092e3f8f81d953ce39 

Diff: https://reviews.apache.org/r/39018/diff/


Testing
-------

New code was added to `ResourcesTest.ParsingFromJSON`, and two new tests were added: `ResourcesTest.ParsingFromJSONWithRoles`
and `ResourcesTest.ParsingFromJSONError`. These attempt to test common error scenarios that
might show up in user-supplied JSON.

`make check` was used to confirm that all tests pass, with one notable failure (ResourcesTest.ParsingFromJSONError)
related to a picojson issue tracked here: https://issues.apache.org/jira/browse/MESOS-3698

The original resources parsing format is used throughout many other tests (check `src/tests/sorter_tests.cpp`,
for example), so it's clear that the original parsing continues to work correctly.


Thanks,

Greg Mann


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message