mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Park" <mcyp...@gmail.com>
Subject Re: Review Request 39388: Explicitly set the `LIBPROCESS_IP` env variable for docker containers.
Date Sat, 17 Oct 2015 23:18:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39388/
-----------------------------------------------------------

(Updated Oct. 17, 2015, 11:18 p.m.)


Review request for mesos and Niklas Nielsen.


Changes
-------

Added a test, expanded upon the comment


Bugs: MESOS-3740
    https://issues.apache.org/jira/browse/MESOS-3740


Repository: mesos


Description
-------

See summary.


Diffs (updated)
-----

  src/docker/docker.cpp 56d63dc75637c9f89a239af371f476a85a570696 
  src/tests/containerizer/docker_containerizer_tests.cpp 4bb65afd0ee61cafef68e064a697fdce65d60058


Diff: https://reviews.apache.org/r/39388/diff/


Testing (updated)
-------

Added `DockerContainerizerTest.ROOT_DOCKER_LaunchWithLibprocessIP` test which fails without
the changes made to `src/docker/docker.cpp`.


Thanks,

Michael Park


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message