mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 39380: Windows: Added support for `stout/flags/flags.hpp`.
Date Fri, 16 Oct 2015 20:15:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39380/#review102978
-----------------------------------------------------------

Ship it!



3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp (line 20)
<https://reviews.apache.org/r/39380/#comment160809>

    Is this addition related?
    
    (It's good to have nevertheless.)


- Joseph Wu


On Oct. 16, 2015, 12:50 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39380/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2015, 12:50 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Added support for `stout/flags/flags.hpp`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp b91318cfd5748b3387bb6b32b910f327853274dd

>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp e34ed78386130a1e757be1b1f1a2dbf794b7cd37

> 
> Diff: https://reviews.apache.org/r/39380/diff/
> 
> 
> Testing
> -------
> 
> CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 on Windows
10.
> 
> Autotools `make check` on Ubuntu 15.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message