mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marco Massenzio" <ma...@mesosphere.io>
Subject Re: Review Request 39386: Fix uncorrect launcher dir in docker executor.
Date Fri, 16 Oct 2015 17:30:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39386/#review102939
-----------------------------------------------------------

Ship it!


Thanks for doing this.

I think you will need to document the flags' usage in `configuration.md` (or wherever appropriate)
and state clearly that it's **required** and what it should point to (in other words, what
binary(ies) will we be looking for?) - or users will be confused by the error message.


src/docker/executor.hpp (line 64)
<https://reviews.apache.org/r/39386/#comment160768>

    Please note it is a "required" option and what it it is meant to be used for (and, ideally,
what it should point to).


- Marco Massenzio


On Oct. 16, 2015, 5:17 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39386/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2015, 5:17 a.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-3738
>     https://issues.apache.org/jira/browse/MESOS-3738
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix uncorrect launcher dir in docker executor.
> 
> 
> Diffs
> -----
> 
>   src/docker/executor.hpp 8ab4e98c41017e8420b98c63a59d8e4bc1a99172 
>   src/docker/executor.cpp 1e4901335854c49e46cd7b132e79ccb11cd72ade 
>   src/slave/containerizer/docker.cpp 702295808475c092dff66417f42af89b90e6d50d 
> 
> Diff: https://reviews.apache.org/r/39386/diff/
> 
> 
> Testing
> -------
> 
> * make check
> * make install and then test with marathon to check if launcher_dir passes correctly.
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message