mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Clemmer" <clemmer.alexan...@gmail.com>
Subject Re: Review Request 39262: Windows:[1/3] Moved `os::environ` -> `os::raw::environment`.
Date Thu, 15 Oct 2015 20:33:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39262/
-----------------------------------------------------------

(Updated Oct. 15, 2015, 8:33 p.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.


Repository: mesos


Description
-------

Windows standard headers define a macro, `environ`, that holds the
environment data for the executing process. Unfortunately, the existance
of this macro makes it impossible to use a function called
`os::environ`.

Our solution to this problem in this commit is to move the function
family at `os::environ`* to `os::raw::environment`. This family exists
in the `os::raw` because they are the "unstructured" variants of
functions with the same names that exist in the `os` namespace. For
example, `os::raw::environment` returns a `char**` which is the
"unstructured" equivalent of `os::environment`, which returns a
`map<string, string>`.


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 9e9c3119ad18f4cbc70c70095c71dc4fd19553df

  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 5141c1369af60afd6cd5c70c6295d575ea960a83

  3rdparty/libprocess/3rdparty/stout/include/stout/os/raw/environment.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp a042d061159c83e1652e7288b90809981d2818c9

  3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 2b0966889af73238a08e29f1136d0ce286a0ffda

  3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp ee2a7a79617612ed448e650cc77608c4962fe5a5


Diff: https://reviews.apache.org/r/39262/diff/


Testing
-------

`make check` on Ubuntu 15, OS X 10.10, and running the `check` project on Windows 10.


Thanks,

Alex Clemmer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message