mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Neil Conway" <neil.con...@gmail.com>
Subject Re: Review Request 39323: Fixed syntax error in sed usage on OSX.
Date Wed, 14 Oct 2015 23:41:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39323/
-----------------------------------------------------------

(Updated Oct. 14, 2015, 11:41 p.m.)


Review request for mesos and Joris Van Remoortere.


Changes
-------

Replace "sed" with $(SED)


Bugs: MESOS-3734
    https://issues.apache.org/jira/browse/MESOS-3734


Repository: mesos


Description
-------

5d246ce4e2d40b adopted sed syntax that works on Linux but does not work on
OSX. Apparently there is not a portable way to instruct sed not to make a backup
file; hence, we now create a backup file and then immediately delete it.


Diffs (updated)
-----

  src/Makefile.am 2bf40f27733b4362d64679bf594e15e82f47155d 

Diff: https://reviews.apache.org/r/39323/diff/


Testing
-------

Successfully built on OSX.


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message