mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 39210: Windows: Moved `realpath` to its own file, `stout/os/realpath.hpp`.
Date Tue, 13 Oct 2015 18:20:30 GMT


> On Oct. 12, 2015, 2:29 p.m., Joseph Wu wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/realpath.hpp, line 25
> > <https://reviews.apache.org/r/39210/diff/2/?file=1094558#file1094558line25>
> >
> >     Don't you need to include `windows.hpp` to get `PATH_MAX` (on Windows, of course)?
> 
> Alex Clemmer wrote:
>     We don't need to because result.hpp includes abort.hpp which includes windows.hpp.
>     
>     That said, it might be better to include it here also. What do you think? I don't
see a clear advantage either way.

We generally try (emphasis on "try") to have a single level of include dependency in all our
files.  So I'd vote to include it.


- Joseph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39210/#review102331
-----------------------------------------------------------


On Oct. 10, 2015, 5:23 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39210/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2015, 5:23 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-3632
>     https://issues.apache.org/jira/browse/MESOS-3632
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Moved `realpath` to its own file, `stout/os/realpath.hpp`.
> 
> (NOTE: This does not resolve MESOS-3632, it's only a partial solution.)
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 9e9c3119ad18f4cbc70c70095c71dc4fd19553df

>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 5141c1369af60afd6cd5c70c6295d575ea960a83

>   3rdparty/libprocess/3rdparty/stout/include/stout/os/realpath.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/exists.hpp ddcda7bdb294272a7a64a7a46e0576e8c4430eec

> 
> Diff: https://reviews.apache.org/r/39210/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message