-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39276/#review102462
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39276]
All tests passed.
- Mesos ReviewBot
On Oct. 13, 2015, 3 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39276/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2015, 3 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Bernd Mathiske, and Till Toenshoff.
>
>
> Bugs: MESOS-3705
> https://issues.apache.org/jira/browse/MESOS-3705
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When using the same socket to send multiple HTTP requests to different actors. If the
actor responsible for handling the first request is stuck handling another event while a subsequent
request can reply immediatly, the order of the responses is altered violating HTTP Pipelining.
>
> This patch fixes that problem enforcing that every response is sent in the order the
corresponding request arrived. It also adds a test to reproduce the issue and verify the fix
works.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/event.hpp 16ddbd77afa6efdf6bad201aa497ee102aa863ae
> 3rdparty/libprocess/src/process.cpp d1c81f1d244f02bf42cab97198587ce1b8c7c407
> 3rdparty/libprocess/src/tests/http_tests.cpp 38f3ad7e46f5b6ef4850cdf7fdcc115715e98472
>
> Diff: https://reviews.apache.org/r/39276/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
|