mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 39007: libprocess: Used thread-safe replacement for strerror.
Date Fri, 09 Oct 2015 00:12:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39007/#review101988
-----------------------------------------------------------


Patch looks great!

Reviews applied: [39005, 39007]

All tests passed.

- Mesos ReviewBot


On Oct. 8, 2015, 6:15 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39007/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2015, 6:15 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3551
>     https://issues.apache.org/jira/browse/MESOS-3551
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Switch call sites to using safe strerror_r wrapper.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/io.cpp 26686e1a96484e3f09d41a7292f38b7579ce9c48 
>   3rdparty/libprocess/src/poll_socket.cpp 28ed102972a9d8f88048aea4046ed837b6a25b35 
>   3rdparty/libprocess/src/process.cpp d1c81f1d244f02bf42cab97198587ce1b8c7c407 
>   3rdparty/libprocess/src/profiler.cpp 0c515568880aa6b7a65cfe2955eb7132bdfb3baf 
>   3rdparty/libprocess/src/subprocess.cpp a457cbe35ad33531c49f74550cd570cf28758f5d 
> 
> Diff: https://reviews.apache.org/r/39007/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message