mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Peach" <jpe...@apache.org>
Subject Re: Review Request 39138: Renamed libprocess tests to libprocess-tests.
Date Thu, 08 Oct 2015 22:59:28 GMT


> On Oct. 8, 2015, 9:24 p.m., James Peach wrote:
> > You should also rename ```benchmarks``` and ```ssl-client```.
> 
> Kapil Arya wrote:
>     Good suggestion. But I think, it will be better to do that in a separate RR (just
to keep this RR chain strictly relevant for `make tests`).

It will take longer to file the tickets and reviews than to just make the change now :)


- James


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39138/#review101957
-----------------------------------------------------------


On Oct. 8, 2015, 7:28 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39138/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2015, 7:28 p.m.)
> 
> 
> Review request for mesos, James Peach and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3584
>     https://issues.apache.org/jira/browse/MESOS-3584
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/Makefile.am c764717d447da39f78a9c74a756e611b63a814e1 
> 
> Diff: https://reviews.apache.org/r/39138/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message