mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anand Mazumdar" <mazumdar.an...@gmail.com>
Subject Re: Review Request 38875: Moved the framework/executor exists check before Subscribe call in Agent
Date Tue, 06 Oct 2015 02:58:15 GMT


> On Sept. 30, 2015, 5 a.m., Guangya Liu wrote:
> > src/slave/http.cpp, line 304
> > <https://reviews.apache.org/r/38875/diff/1/?file=1087515#file1087515line304>
> >
> >     Can you please add some comments for when this if condition will be hit? I see
that the scheduler API is not handling such logic.

It should be : https://github.com/apache/mesos/blob/master/src/master/http.cpp#L465

The only difference here being that we also need to explicitly check for the state to be `REGISTERING`
as the agent creates an executor object when it receives a `RunTaskMessage` from the master


- Anand


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38875/#review101074
-----------------------------------------------------------


On Sept. 30, 2015, 3:39 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38875/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2015, 3:39 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
> 
> 
> Bugs: MESOS-3515
>     https://issues.apache.org/jira/browse/MESOS-3515
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Refactored the `api/v1/executor` endpoint to do executor/framework exists(`NULL`) checks
before `Subscribe` since the slave explicitly knows the `frameworkID/executorID` when it launches
it. Also modified tests to first spawn a dummy `cat` process and then make a `Subscribe` call
to ensure that the Agent knows about the Framework/Executor and not reject it via `BadRequest`
due to the `NULL` checks.
> 
> 
> Diffs
> -----
> 
>   src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b 
>   src/tests/executor_http_api_tests.cpp 31938c295367686d444f8a8aa2c43d2696b481ec 
> 
> Diff: https://reviews.apache.org/r/38875/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message