mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Chen" <tnac...@apache.org>
Subject Re: Review Request 38901: Serialize Docker Image Spec as Protobuf
Date Mon, 05 Oct 2015 21:20:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38901/#review101533
-----------------------------------------------------------



src/slave/containerizer/provisioner/docker/message.proto (line 79)
<https://reviews.apache.org/r/38901/#comment158949>

    End all comments with period. And add a space in the beginning:
    
    // JSON Web key.


- Timothy Chen


On Oct. 5, 2015, 7:21 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38901/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2015, 7:21 p.m.)
> 
> 
> Review request for mesos, Jojy Varghese and Timothy Chen.
> 
> 
> Bugs: MESOS-2972
>     https://issues.apache.org/jira/browse/MESOS-2972
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Serialize Docker Image Spec as Protobuf
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 891f951f3107ece29b7923b7a3cc414e2ea56983 
>   src/Makefile.am f060998bb08cdb071db5a2e85dfbad805dab45e9 
>   src/slave/containerizer/provisioner/docker/message.proto bbac2e6c1f40a7ca3f9227baca56a44cd43f58c6

>   src/slave/containerizer/provisioner/docker/spec.hpp PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/spec.cpp PRE-CREATION 
>   src/tests/containerizer/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c

> 
> Diff: https://reviews.apache.org/r/38901/diff/
> 
> 
> Testing
> -------
> 
> make check (ubuntu 14.04 + clang++-3.6)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message