mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 39013: RegistryClient refactor: Fixed comments style.
Date Mon, 05 Oct 2015 21:07:50 GMT


> On Oct. 5, 2015, 9:07 p.m., Ben Mahler wrote:
> > I'd like to ship these smaller fixes, but they depend on the large refactor patch
and the patch for new functionality, so I can't apply the change :(
> > 
> > Please put the small cleanup patches at the front of your change so that they aren't
blocked on your other patches, that way we can incrementally commit these :)

s/change/chain/


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39013/#review101530
-----------------------------------------------------------


On Oct. 5, 2015, 8:58 p.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39013/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2015, 8:58 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> RegistryClient refactor: Fixed comments style.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/provisioner/docker/registry_client.hpp 9d5d15455192e2d75fe5cd7fa8755fb8cc67e185

>   src/slave/containerizer/provisioner/docker/registry_client.cpp c2040b48ea43fdb29766994c244273d3fa9ee3cd

> 
> Diff: https://reviews.apache.org/r/39013/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message