Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AA99E18FAD for ; Wed, 23 Sep 2015 17:09:20 +0000 (UTC) Received: (qmail 70387 invoked by uid 500); 23 Sep 2015 17:09:20 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 70360 invoked by uid 500); 23 Sep 2015 17:09:20 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 70345 invoked by uid 99); 23 Sep 2015 17:09:20 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 Sep 2015 17:09:20 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 25F6128622C; Wed, 23 Sep 2015 17:09:18 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3826384637386610860==" MIME-Version: 1.0 Subject: Re: Review Request 38575: Added masterSlaveLostHook From: "haosdent huang" To: "Joris Van Remoortere" , "Kapil Arya" Cc: "Niklas Nielsen" , "haosdent huang" , "mesos" Date: Wed, 23 Sep 2015 17:09:18 -0000 Message-ID: <20150923170918.31021.1879@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "haosdent huang" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/38575/ X-Sender: "haosdent huang" References: <20150921224001.31021.85150@reviews.apache.org> In-Reply-To: <20150921224001.31021.85150@reviews.apache.org> Reply-To: "haosdent huang" X-ReviewRequest-Repository: mesos --===============3826384637386610860== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38575/#review100221 ----------------------------------------------------------- Ship it! Ship It! - haosdent huang On Sept. 21, 2015, 10:40 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38575/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2015, 10:40 p.m.) > > > Review request for mesos, Joris Van Remoortere and Kapil Arya. > > > Bugs: MESOS-3015 > https://issues.apache.org/jira/browse/MESOS-3015 > > > Repository: mesos > > > Description > ------- > > This patch adds a new masterSlaveLost hook to enable modules to clean up after lost slaves events (as in networking modules, where we want to avoid leaking IPs). > > > Diffs > ----- > > include/mesos/hook.hpp 2353602c8ac8b89e3fa86bda7d1e262a3debef80 > src/examples/test_hook_module.cpp 0dc74d60576af6f88cbdc1c9a6f82348c5761d2f > src/hook/manager.hpp a517c05855b07831a9728c1191243d114781b70a > src/hook/manager.cpp 691976e94d5ac9fe4f8ba583214f24900d14248c > src/master/master.cpp 90ef8c663c90ffbdcb4aa2377bfba65ea5d3fda9 > src/tests/hook_tests.cpp b23a587c683c391ca860b3b7d876902987f4d158 > > Diff: https://reviews.apache.org/r/38575/diff/ > > > Testing > ------- > > make check with new masterSlaveLostHook test > > > Thanks, > > Niklas Nielsen > > --===============3826384637386610860==--