Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D7A53179F4 for ; Wed, 23 Sep 2015 07:50:30 +0000 (UTC) Received: (qmail 31047 invoked by uid 500); 23 Sep 2015 07:50:30 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 31022 invoked by uid 500); 23 Sep 2015 07:50:30 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 31003 invoked by uid 99); 23 Sep 2015 07:50:30 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 Sep 2015 07:50:30 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 5548C1D9CEB; Wed, 23 Sep 2015 07:50:28 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6514588051933689191==" MIME-Version: 1.0 Subject: Re: Review Request 38137: Added Docker provisioner, store and local puller From: "Jiang Yan Xu" To: "Jiang Yan Xu" , "Till Toenshoff" , "Jie Yu" , "Jojy Varghese" Cc: "mesos" , "Timothy Chen" Date: Wed, 23 Sep 2015 07:50:28 -0000 Message-ID: <20150923075028.24659.20921@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Jiang Yan Xu" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/38137/ X-Sender: "Jiang Yan Xu" References: <20150922221553.24659.57156@reviews.apache.org> In-Reply-To: <20150922221553.24659.57156@reviews.apache.org> Reply-To: "Jiang Yan Xu" X-ReviewRequest-Repository: mesos --===============6514588051933689191== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38137/#review100165 ----------------------------------------------------------- src/slave/containerizer/provisioner/docker/puller.hpp (line 60) If we use LinkedHashMap we don't need to create another struct right? - Jiang Yan Xu On Sept. 22, 2015, 3:15 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38137/ > ----------------------------------------------------------- > > (Updated Sept. 22, 2015, 3:15 p.m.) > > > Review request for mesos, Jie Yu, Jojy Varghese, Till Toenshoff, and Jiang Yan Xu. > > > Repository: mesos > > > Description > ------- > > Joining all the commits around provisioner and local store into one review so it's easier to review, as patches > are changing code on top of each other. > > All the commits are going to committed together. > > > Diffs > ----- > > src/Makefile.am e224060 > src/slave/containerizer/provisioner/docker/local_puller.hpp PRE-CREATION > src/slave/containerizer/provisioner/docker/local_puller.cpp PRE-CREATION > src/slave/containerizer/provisioner/docker/message.hpp PRE-CREATION > src/slave/containerizer/provisioner/docker/message.proto PRE-CREATION > src/slave/containerizer/provisioner/docker/metadata_manager.hpp PRE-CREATION > src/slave/containerizer/provisioner/docker/metadata_manager.cpp PRE-CREATION > src/slave/containerizer/provisioner/docker/paths.hpp PRE-CREATION > src/slave/containerizer/provisioner/docker/paths.cpp PRE-CREATION > src/slave/containerizer/provisioner/docker/puller.hpp PRE-CREATION > src/slave/containerizer/provisioner/docker/puller.cpp PRE-CREATION > src/slave/containerizer/provisioner/docker/store.hpp PRE-CREATION > src/slave/containerizer/provisioner/docker/store.cpp PRE-CREATION > src/slave/containerizer/provisioner/store.cpp 35d1199 > src/slave/flags.hpp e31a418 > src/slave/flags.cpp add4196 > src/tests/containerizer/provisioner_docker_tests.cpp 1b0c304 > > Diff: https://reviews.apache.org/r/38137/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > > --===============6514588051933689191==--