Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DBFD817C4C for ; Tue, 22 Sep 2015 18:58:46 +0000 (UTC) Received: (qmail 72830 invoked by uid 500); 22 Sep 2015 18:58:46 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 72803 invoked by uid 500); 22 Sep 2015 18:58:46 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 72787 invoked by uid 99); 22 Sep 2015 18:58:46 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Sep 2015 18:58:46 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 3EB7E28492C; Tue, 22 Sep 2015 18:58:44 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3531369558058827173==" MIME-Version: 1.0 Subject: Re: Review Request 38639: Add os::clone function in stout. From: "Kapil Arya" To: "Jie Yu" , "Cong Wang" Cc: "haosdent huang" , "mesos" Date: Tue, 22 Sep 2015 18:58:44 -0000 Message-ID: <20150922185844.24659.79104@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Kapil Arya" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/38639/ X-Sender: "Kapil Arya" References: <20150922183653.31021.45022@reviews.apache.org> In-Reply-To: <20150922183653.31021.45022@reviews.apache.org> Reply-To: "Kapil Arya" X-ReviewRequest-Repository: mesos --===============3531369558058827173== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38639/#review100046 ----------------------------------------------------------- Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp (line 73) We should delete the stack only if CLONE_VM was not specified in the flags or at least have a comment mentioning the fact that this call is creating a new process and not a new thread. Having a CLONE_VM will create a new thread, not a new process. - Kapil Arya On Sept. 22, 2015, 2:36 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38639/ > ----------------------------------------------------------- > > (Updated Sept. 22, 2015, 2:36 p.m.) > > > Review request for mesos, Jie Yu and Cong Wang. > > > Bugs: MESOS-3474 > https://issues.apache.org/jira/browse/MESOS-3474 > > > Repository: mesos > > > Description > ------- > > Add os::clone function in stout. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp b994b13941628947c9d12b8baae155d5da1ec7bd > > Diff: https://reviews.apache.org/r/38639/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > > --===============3531369558058827173==--