Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6774518E3A for ; Tue, 22 Sep 2015 06:18:43 +0000 (UTC) Received: (qmail 1556 invoked by uid 500); 22 Sep 2015 06:18:37 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 1529 invoked by uid 500); 22 Sep 2015 06:18:37 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 1512 invoked by uid 99); 22 Sep 2015 06:18:36 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Sep 2015 06:18:36 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B692A285A7F; Tue, 22 Sep 2015 06:18:34 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5243493538955087555==" MIME-Version: 1.0 Subject: Review Request 38595: Removed implicit logging from Socket::shutdown in favor of returning a Try. From: "Ben Mahler" To: "Joris Van Remoortere" , "Vinod Kone" , "Jie Yu" Cc: "Ben Mahler" , "mesos" Date: Tue, 22 Sep 2015 06:18:34 -0000 Message-ID: <20150922061834.24659.61031@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Ben Mahler" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/38595/ X-Sender: "Ben Mahler" Reply-To: "Ben Mahler" X-ReviewRequest-Repository: mesos --===============5243493538955087555== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38595/ ----------------------------------------------------------- Review request for mesos, Jie Yu, Joris Van Remoortere, and Vinod Kone. Repository: mesos Description ------- See summary, should this also not be an ERROR? Diffs ----- 3rdparty/libprocess/include/process/socket.hpp a677e29b28711fc065134c11792b4f62fa3aa8b4 3rdparty/libprocess/src/libevent_ssl_socket.hpp 3b17fa278a92461cf74179084a717909224c3d9c 3rdparty/libprocess/src/libevent_ssl_socket.cpp 80db6e83f14de5fd241565009d8a60aa964e790c 3rdparty/libprocess/src/process.cpp 4afa30569b4d235637b49a624602e6b199c32e0e Diff: https://reviews.apache.org/r/38595/diff/ Testing ------- make check Thanks, Ben Mahler --===============5243493538955087555==--