Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7482D17D32 for ; Thu, 17 Sep 2015 21:42:16 +0000 (UTC) Received: (qmail 16157 invoked by uid 500); 17 Sep 2015 21:42:16 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 16132 invoked by uid 500); 17 Sep 2015 21:42:16 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 16087 invoked by uid 99); 17 Sep 2015 21:42:16 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Sep 2015 21:42:16 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 83057283FEC; Thu, 17 Sep 2015 21:42:14 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4424137606391338008==" MIME-Version: 1.0 Subject: Re: Review Request 37873: Add quiesce logic in allocator From: "Vinod Kone" To: "Vinod Kone" , "Alexander Rukletsov" , "Jie Yu" , "Ben Mahler" Cc: "Guangya Liu" , "mesos" Date: Thu, 17 Sep 2015 21:42:14 -0000 Message-ID: <20150917214214.3773.77595@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Vinod Kone" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/37873/ X-Sender: "Vinod Kone" References: <20150916055041.3773.50289@reviews.apache.org> In-Reply-To: <20150916055041.3773.50289@reviews.apache.org> Reply-To: "Vinod Kone" X-ReviewRequest-Repository: mesos --===============4424137606391338008== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37873/#review99450 ----------------------------------------------------------- src/tests/mesos.hpp (line 1608) Needs a test for the scheduler driver. I've only see one for the http scheduler library. Also, can you send a review for CHANGELOG and upgrades.md updates for 0.25.0? feel free to send that after this chain gets committed, to avoid making this chain even bigger. - Vinod Kone On Sept. 16, 2015, 5:50 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37873/ > ----------------------------------------------------------- > > (Updated Sept. 16, 2015, 5:50 a.m.) > > > Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod Kone. > > > Bugs: MESOS-3037 > https://issues.apache.org/jira/browse/MESOS-3037 > > > Repository: mesos > > > Description > ------- > > Add quiesce logic in allocator > > > Diffs > ----- > > include/mesos/master/allocator.hpp fb09e2a6502bc8c78ddcc8a595bcd9320da136ea > src/master/allocator/mesos/allocator.hpp 171548b2017a0b97124f052c21345668e274d117 > src/master/allocator/mesos/hierarchical.hpp 3374d63b8311cf10b3108f56b7b167c12a9d7a37 > src/master/master.cpp f26271c5b21685916c0654488ac1464f21d72e9a > src/tests/mesos.hpp 3db97aca921c9216d90384e1eb17030849516454 > > Diff: https://reviews.apache.org/r/37873/diff/ > > > Testing > ------- > > > Thanks, > > Guangya Liu > > --===============4424137606391338008==--