Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 74077178C0 for ; Fri, 11 Sep 2015 21:44:58 +0000 (UTC) Received: (qmail 22142 invoked by uid 500); 11 Sep 2015 21:44:42 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 22116 invoked by uid 500); 11 Sep 2015 21:44:42 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 22092 invoked by uid 99); 11 Sep 2015 21:44:42 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 Sep 2015 21:44:42 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 607A92730FA; Fri, 11 Sep 2015 21:44:41 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5841940091595763569==" MIME-Version: 1.0 Subject: Re: Review Request 37821: Join threads in libprocess when shutting down. From: "Mesos ReviewBot" To: "Artem Harutyunyan" , "Benjamin Hindman" , "Joris Van Remoortere" , "Joseph Wu" , "Michael Park" Cc: "mesos" , "Greg Mann" , "Mesos ReviewBot" Date: Fri, 11 Sep 2015 21:44:41 -0000 Message-ID: <20150911214441.1695.90333@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Mesos ReviewBot" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/37821/ X-Sender: "Mesos ReviewBot" References: <20150911142639.12750.59196@reviews.apache.org> In-Reply-To: <20150911142639.12750.59196@reviews.apache.org> Reply-To: "Mesos ReviewBot" X-ReviewRequest-Repository: mesos --===============5841940091595763569== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37821/#review98693 ----------------------------------------------------------- Patch looks great! Reviews applied: [37821] All tests passed. - Mesos ReviewBot On Sept. 11, 2015, 2:26 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37821/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2015, 2:26 p.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Michael Park. > > > Bugs: MESOS-3158 > https://issues.apache.org/jira/browse/MESOS-3158 > > > Repository: mesos > > > Description > ------- > > Join threads in libprocess when shutting down. > > > Diffs > ----- > > 3rdparty/libprocess/src/event_loop.hpp 36a4cd2b1ff59f6922173ad17115bf80cc3c8f30 > 3rdparty/libprocess/src/libev.cpp 97a2694f9b10bc61841443b21f4f96055493e840 > 3rdparty/libprocess/src/libevent.cpp ee7906470069b0391dde7cd685b1d4eb3a158c03 > 3rdparty/libprocess/src/process.cpp 4afa30569b4d235637b49a624602e6b199c32e0e > > Diff: https://reviews.apache.org/r/37821/diff/ > > > Testing > ------- > > After configuring with both "../configure" and "../configure --enable-libevent --enable-ssl": > > make check > > > Also, to check for race conditions related to the initialization/shutdown of libprocess, try something like: > > for n in {1..1000}; do echo $n; 3rdparty/libprocess/tests --gtest_filter=ProcessTest.Spawn; done > > > Thanks, > > Greg Mann > > --===============5841940091595763569==--