mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Clemmer" <clemmer.alexan...@gmail.com>
Subject Re: Review Request 38756: CMake: Add support for compiling the agent with CMake.
Date Fri, 25 Sep 2015 22:45:34 GMT


> On Sept. 25, 2015, 9:36 p.m., Artem Harutyunyan wrote:
> > src/CMakeLists.txt, line 1
> > <https://reviews.apache.org/r/38756/diff/1/?file=1084616#file1084616line1>
> >
> >     I think this file belongs in src/slave. And from top level src/ dir we should
just be pulling CMakeLists.txt files from component directories. What do you think?

Personally, I think We should do that only if the goal is to build a libagent binary.

If we don't plan on doing that, I don't think it buys us much. For example, if you look at
the WIP commit that builds the master (https://github.com/hausdorff/mesos/commits/cmake_agent),
we just have a bunch of variables like `MASTER_SRC` that break up the source by component
(master, isolator, etc.) and compile it all at once. It's pretty clean, and moving each of
those things to its own file really only means that you have to go to another file to see
what `AGENT_SRC` has in it.

BUT, if we plan to ship libagent, libmaster, etc., then it does make sense, because they're
all individual things.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38756/#review100641
-----------------------------------------------------------


On Sept. 25, 2015, 10:14 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38756/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2015, 10:14 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-3385
>     https://issues.apache.org/jira/browse/MESOS-3385
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> CMake: Add support for compiling the agent with CMake.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3 
>   cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8 
>   src/CMakeLists.txt PRE-CREATION 
>   src/cmake/MesosProtobuf.cmake PRE-CREATION 
>   src/slave/cmake/AgentConfigure.cmake PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38756/diff/
> 
> 
> Testing
> -------
> 
> Compiled and ran made sure libprocess and stout tests ran and passed on the following
platforms:
> 
> * OS X 10.10
> * Ubuntu 14.04.2
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message