mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Artem Harutyunyan" <ar...@mesosphere.io>
Subject Re: Review Request 38551: [1/2]CMake: Add version info for APR we need to build Windows.
Date Fri, 25 Sep 2015 17:04:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38551/#review100610
-----------------------------------------------------------


LGTM.

- Artem Harutyunyan


On Sept. 21, 2015, 11:30 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38551/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2015, 11:30 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-3383
>     https://issues.apache.org/jira/browse/MESOS-3383
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> [1/2]CMake: Add version info for APR we need to build Windows.
> 
> 
> Diffs
> -----
> 
>   3rdparty/cmake/Versions.cmake PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38551/diff/
> 
> 
> Testing
> -------
> 
> Compiled and ran made sure libprocess and stout tests ran and passed on the following
platforms:
> 
> * OS X 10.10
> * Windows 10
> * Ubuntu 14.04.2
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message