mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "haosdent huang" <haosd...@gmail.com>
Subject Re: Review Request 38550: [2/2]CMake: Integrate libevent into Windows builds.
Date Fri, 25 Sep 2015 16:13:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38550/#review100587
-----------------------------------------------------------

Ship it!


Ship It!

- haosdent huang


On Sept. 21, 2015, 10:43 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38550/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2015, 10:43 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-3380
>     https://issues.apache.org/jira/browse/MESOS-3380
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Since there is no robust standalone libev support on Windows, Mesos will
> need to use libevent to support Windows, at least in the short term.
> 
> This commit will add logic to configure, build, and install libevent for
> all Windows builds.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt b9c9fae7d448906e9c9f5ab0ee3fe138a0171a7d

>   3rdparty/libprocess/cmake/ProcessConfigure.cmake a5f8d399e151acad87bb72ecb1f7372b2c467423

> 
> Diff: https://reviews.apache.org/r/38550/diff/
> 
> 
> Testing
> -------
> 
> Compiled and ran made sure libprocess and stout tests ran and passed on the following
platforms:
> 
> * OS X 10.10
> * Windows 10
> * Ubuntu 14.04.2
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message