mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anand Mazumdar" <mazumdar.an...@gmail.com>
Subject Re: Review Request 38645: Fixed Flaky Executor HTTP tests
Date Thu, 24 Sep 2015 23:09:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38645/
-----------------------------------------------------------

(Updated Sept. 24, 2015, 11:09 p.m.)


Review request for mesos, Isabel Jimenez and Vinod Kone.


Changes
-------

Address comments from Vinod


Repository: mesos


Description
-------

This showed up on ASF CI. From the logs:

`I0922 17:31:49.819221 28463 slave.cpp:4104] Finished recoveryā€¯`
Then ....
`../../src/tests/executor_http_api_tests.cpp:290: Failure`
`Failed to wait 15secs for __recover`

Instead of doing a `FUTURE_DISPATCH` after `StartSlave()` we should be doing it before starting
the slave. In some cases, slave would have already recovered by the time we invoke `FUTURE_DISPATCH`
leading to the flakiness.


Diffs (updated)
-----

  src/tests/executor_http_api_tests.cpp 9dbc5191b5950df2faa693720f3740e97c7df758 

Diff: https://reviews.apache.org/r/38645/diff/


Testing
-------

Introduced a sleep before `AWAIT_READY`, the test failed. After this change with the sleep
it still passed.

Ran in a loop 100 times.

ASF CI error log: https://builds.apache.org/job/Mesos/COMPILER=gcc,CONFIGURATION=--verbose,OS=ubuntu%3A14.04,label_exp=docker%7C%7CHadoop/839/changes


Thanks,

Anand Mazumdar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message