mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joris Van Remoortere" <joris.van.remoort...@gmail.com>
Subject Review Request 38726: Make common attributes symmetrical to v1 attributes.
Date Thu, 24 Sep 2015 18:28:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38726/
-----------------------------------------------------------

Review request for mesos and Benjamin Hindman.


Repository: mesos


Description
-------

This aids in verifying the files are kept in sync.
diff src/common/attributes.cpp src/v1/attributes.cpp should result
in only include and namespace differences.


Diffs
-----

  src/common/attributes.cpp 8a8d6245135aff0a6cfde8dee46640770c38ed0d 

Diff: https://reviews.apache.org/r/38726/diff/


Testing
-------

diff src/common/attributes.cpp src/v1/attributes.cpp 
```
24,25c24,25
< #include <mesos/attributes.hpp>
< #include <mesos/values.hpp>
---
> #include <mesos/v1/attributes.hpp>
> #include <mesos/v1/values.hpp>
34d33
< 
35a35
> namespace v1 {
227a228
> } // namespace v1 {
```


Thanks,

Joris Van Remoortere


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message