mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niklas Nielsen" <...@qni.dk>
Subject Re: Review Request 38637: Added recovery warnings for LinuxLauncher on Systemd.
Date Wed, 23 Sep 2015 20:29:38 GMT


> On Sept. 22, 2015, 8:49 p.m., Mesos ReviewBot wrote:
> > Bad patch!
> > 
> > Reviews applied: [38634, 38635]
> > 
> > Failed command: ./support/apply-review.sh -n -r 38635
> > 
> > Error:
> >  2015-09-23 03:49:49 URL:https://reviews.apache.org/r/38635/diff/raw/ [9385/9385]
-> "38635.patch" [1]
> > 38635.patch:232: new blank line at EOF.
> > +
> > warning: 1 line adds whitespace errors.
> > Successfully applied: Create and Start `mesos_executor.slice` in LinuxLauncher on
Systemd.
> > 
> > See summary.
> > 
> > 
> > Review: https://reviews.apache.org/r/38635
> > src/linux/systemd.cpp:205: new blank line at EOF.
> > Failed to commit patch

Style nit ^^


- Niklas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38637/#review100129
-----------------------------------------------------------


On Sept. 22, 2015, 6:48 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38637/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2015, 6:48 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Niklas Nielsen,
Thomas Rampelberg, and Timothy Chen.
> 
> 
> Bugs: MESOS-3425
>     https://issues.apache.org/jira/browse/MESOS-3425
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/linux_launcher.cpp fd0ffcf838a745ccd458d57821d358eceb85be26

> 
> Diff: https://reviews.apache.org/r/38637/diff/
> 
> 
> Testing
> -------
> 
> make check
> on ubuntu 15.04 with systemd 219 verified that pids get assigned to the `mesos_executor.slice`,
and operator is warned about lack of proper resource isolation upon recovery if the executor
pid is no longer in the slice.
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message