mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 38639: Add os::clone function in stout.
Date Wed, 23 Sep 2015 06:07:55 GMT


> On Sept. 22, 2015, 6:55 p.m., Cong Wang wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp, line 52
> > <https://reviews.apache.org/r/38639/diff/1/?file=1081455#file1081455line52>
> >
> >     s/namespaces/flags/, because SIG* can be or'ed with namespaces. Or even better,
pass namespaces separately with signals as two different parameters?
> 
> haosdent huang wrote:
>     Because I see ::clone only have one param, I just change s/namespaces/flags/ here.
> 
> Cong Wang wrote:
>     I meant:
>     
>     clone(...int flags, int signal)
>     {
>         ::clone(... flags | siganl, ...);
>     }
> 
> haosdent huang wrote:
>     Got it, let me change to that.

I suggest keeping 'flags' for now because 'clone' takes an or'ed flags.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38639/#review100045
-----------------------------------------------------------


On Sept. 23, 2015, 1:26 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38639/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2015, 1:26 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Cong Wang.
> 
> 
> Bugs: MESOS-3474
>     https://issues.apache.org/jira/browse/MESOS-3474
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add os::clone function in stout.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp b994b13941628947c9d12b8baae155d5da1ec7bd

> 
> Diff: https://reviews.apache.org/r/38639/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message