mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 38660: Restore Linux/Posix launcher creation logic for MesosContainerizer.
Date Wed, 23 Sep 2015 05:59:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38660/#review100142
-----------------------------------------------------------


Patch looks great!

Reviews applied: [38660]

All tests passed.

- Mesos ReviewBot


On Sept. 23, 2015, 4:21 a.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38660/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2015, 4:21 a.m.)
> 
> 
> Review request for mesos, haosdent huang and Jie Yu.
> 
> 
> Bugs: MESOS-3498
>     https://issues.apache.org/jira/browse/MESOS-3498
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The current logic uses LinuxLauncher if running as root. However, this causes
> problems with cgroups freezer when we launch multiple Agents inside the test
> suite.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.cpp b4a77e734706f40dc1d2110939d4f33fcbd1fd8c

>   src/slave/flags.hpp e31a4183170c3442ac4a15365c229391e7e91480 
>   src/slave/flags.cpp add4196dfd06c0f602ff5ebd39960dc05c4cd11f 
> 
> Diff: https://reviews.apache.org/r/38660/diff/
> 
> 
> Testing
> -------
> 
> sudo make check currently works for all but one test. Here is the failing case:
> 
> ```
> [----------] 1 test from LimitedCpuIsolatorTest
> [ RUN      ] LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids
> ../../src/tests/containerizer/isolator_tests.cpp:742: Failure
> Value of: usage.get().processes()
>   Actual: 2
> Expected: 1U
> Which is: 1
> ../../src/tests/containerizer/isolator_tests.cpp:743: Failure
> Value of: usage.get().threads()
>   Actual: 2
> Expected: 1U
> Which is: 1
> [  FAILED  ] LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids (187 ms)
> [----------] 1 test from LimitedCpuIsolatorTest (188 ms total)
> 
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (199 ms total)
> [  PASSED  ] 0 tests.
> [  FAILED  ] 1 test, listed below:
> [  FAILED  ] LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids
> 
>  1 FAILED TEST
> ```
> 
> I am still investigating the failure but thought of putting out the review to get some
comments in the meanwhile (and some possible hints :-)).
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message