-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38468/#review99424
-----------------------------------------------------------
Just a few comments related to what I picked up from the sync.
docs/submitting-a-patch.md (line 17)
<https://reviews.apache.org/r/38468/#comment156315>
Can you also add a note about preferring "Accepted" issues rather than "Open" issues?
docs/submitting-a-patch.md (line 62)
<https://reviews.apache.org/r/38468/#comment156316>
Can you add a line here about adding the shepherd to the list of reviewers?
docs/submitting-a-patch.md (line 64)
<https://reviews.apache.org/r/38468/#comment156318>
This line should probably be amended, since we don't want the behavior of wait-until-someone-picks-up-this-review.
You can mention something about pinging (pushing?) the shepherd to do the review, rather
than the other way around.
- Joseph Wu
On Sept. 17, 2015, 11:54 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38468/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2015, 11:54 a.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added suggestion that new contributors seek to find a shepherd for their work
> before their begin writing code. Made a few other improvements.
>
>
> Diffs
> -----
>
> docs/reporting-a-bug.md 6c7f74719a8586f0608eb0f0f77d15c8d534321d
> docs/submitting-a-patch.md 754a16f9b43630880f0f6c4a8e8e2f5e081b0a87
>
> Diff: https://reviews.apache.org/r/38468/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>
|