mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kapil Arya" <ka...@mesosphere.io>
Subject Re: Review Request 38367: Added NetworkInfo message to ContainerInfo and TaskStatus.
Date Tue, 15 Sep 2015 21:06:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38367/
-----------------------------------------------------------

(Updated Sept. 15, 2015, 5:06 p.m.)


Review request for mesos, Connor Doyle, Jie Yu, Niklas Nielsen, and Vinod Kone.


Changes
-------

Addressed Vinod's and Nik's comments.


Bugs: MESOS-3013
    https://issues.apache.org/jira/browse/MESOS-3013


Repository: mesos


Description
-------

This allows the frameworks to specify an intent to enable ip-per-container. The
IP information is supplied back to the framework as well as state.json endpoints
by including NetworkInfo inside TaskStatus.


Diffs (updated)
-----

  include/mesos/mesos.proto b1deed4720cab4a89db76a48bc9563bba4f5bf1c 
  src/common/http.hpp 61ad5314fb14cab0d1cec4fb855fb89b7ac8cf60 
  src/common/http.cpp 9c0d31e261788c492224345b9e0c32643ddb4156 
  src/slave/slave.cpp 5e5522e1254a5ed6084de36782753f9aad2894c4 
  src/tests/master_tests.cpp 8a6b98b9f59ead20f537eb60b5084feed069a5b1 
  src/tests/slave_tests.cpp 5c1a3d36a5f67629aef275eeae12956c524e8102 

Diff: https://reviews.apache.org/r/38367/diff/


Testing
-------

Added new tests and ran make check.


Thanks,

Kapil Arya


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message