mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Klaus Ma" <kl...@cguru.net>
Subject Re: Review Request 38259: [MESOS-3340] Command-line flags should take precedence over OS Env variables
Date Sun, 13 Sep 2015 04:34:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38259/
-----------------------------------------------------------

(Updated Sept. 13, 2015, 4:34 a.m.)


Review request for mesos, Bernd Mathiske, Marco Massenzio, and Michael Park.


Changes
-------

Update the code to overwrite env by cli


Bugs: MESOS-3340
    https://issues.apache.org/jira/browse/MESOS-3340


Repository: mesos


Description
-------

Currently, it appears that re-defining a flag on the command-line that was already defined
via a OS Env var (MESOS_*) causes the Master to fail with a not very helpful message.

For example, if one has MESOS_QUORUM defined, this happens:

    $ ./mesos-master --zk=zk://192.168.1.4/mesos --quorum=1 --hostname=192.168.1.4 --ip=192.168.1.4
    Duplicate flag 'quorum' on command line

which is not very helpful.

Current solution is to throw error if any duplication; over-write may make user confused about
the result.


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 9da213f 
  3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp ebf8cd6 

Diff: https://reviews.apache.org/r/38259/diff/


Testing
-------

make
make check


Thanks,

Klaus Ma


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message