mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 38306: Libprocess: Removed namespace pollution from ssl gtest.
Date Fri, 11 Sep 2015 18:28:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38306/#review98654
-----------------------------------------------------------

Ship it!


LGTM.

Another general question:  Are there plans to move the logic in this file to a .cpp file?

- Joseph Wu


On Sept. 11, 2015, 10:09 a.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38306/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2015, 10:09 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joseph Wu, Michael Park, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This got introduced accidentally while factoring out common test
> fixtures.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/ssl/gtest.hpp a6051b75f0a359ef1bc04e48444f9fd6da9a12dd

> 
> Diff: https://reviews.apache.org/r/38306/diff/
> 
> 
> Testing
> -------
> 
> make check with and without ssl enabled.
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message