mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 38031: [3/5] Integer Precision for JSON <-> Protobuf conversions.
Date Fri, 11 Sep 2015 17:42:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38031/
-----------------------------------------------------------

(Updated Sept. 11, 2015, 10:42 a.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Michael Park,
and Vinod Kone.


Changes
-------

Rebase due to test fix and merge conflict.


Bugs: MESOS-3345
    https://issues.apache.org/jira/browse/MESOS-3345


Repository: mesos


Description
-------

* Changes JSON::Number to keep track of whether it is floating, signed integral, or unsigned
integral.
* Changes how JSON::Number is stringified, to ensure that stringified doubles are parsed as
JSON doubles.
* Added one test for integer precision between String <-> JSON <-> Protobuf conversions.
* Added one test for JSON::Number comparisons.


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp f28138c4682c41e94ab6c7641a78d66b2f9daa5f

  3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 57d5fdf45273c620655b44b5f5572290cffa4bf6

  3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 850650c269e9be24c0f1ae81b8aa8725f8a0c151

  3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp c56d6a3098293eb3659b3066f10e875927ec3ac3


Diff: https://reviews.apache.org/r/38031/diff/


Testing
-------

No testing done until the last patch in the chain.

However, this patch does breaks some libprocess and mesos tests (because JSON::Number is stored
differently), which are fixed in the following two reviews.


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message