mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "haosdent huang" <haosd...@gmail.com>
Subject Re: Review Request 37273: [1/2]Add CMake macro VsBuildCommand in libprocess.
Date Thu, 10 Sep 2015 02:15:15 GMT


> On Sept. 8, 2015, 9:44 p.m., Joseph Wu wrote:
> > Just a bit more cleanup, and I think this would be good to go.
> > 
> > If possible, you should coordinate with Alex Clemmer to make sure this change doesn't
conflict/break what he's working on (https://reviews.apache.org/r/37019/).
> 
> haosdent huang wrote:
>     Thanks a lot.
> 
> Alex Clemmer wrote:
>     I do have things to say about this review, but I need to get the other stuff checked
in with Joris first. There are some things here that I'll ask about, like why we moved the
protobuf stuff out of processtestconfigure.

Yes, when I build 3rdparty, I found protobuf is required(see some error like could not found
protobuf header files and objects) not only when test stage. So I move it from processtestconfigure
to 3rdparty.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37273/#review98026
-----------------------------------------------------------


On Sept. 9, 2015, 2:40 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37273/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2015, 2:40 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and
Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add CMake macro VsBuildCommand in libprocess.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt 997cc0d0e316e316136d4746e50e9e292a82b36b

>   3rdparty/libprocess/cmake/ProcessConfigure.cmake 12506a1369de005285268f895f365aba0c560f78

>   3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 9e4dcb83a8cc4e95a2a38573944f6b38e2eac76e

>   3rdparty/libprocess/cmake/macros/Noop.cmake PRE-CREATION 
>   3rdparty/libprocess/cmake/macros/VsBuildCommand.bat PRE-CREATION 
>   3rdparty/libprocess/cmake/macros/VsBuildCommand.cmake PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37273/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message