Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@mesos.apache.org
Content-Type: multipart/alternative;
 boundary="===============1195817199427169824=="
MIME-Version: 1.0
Subject: Re: Review Request 36908: Added QuotaInfo Protobuf.
From: "Guangya Liu" <gyliu513@gmail.com>
To: "Till Toenshoff" <toenshoff@me.com>,
 "Alexander Rukletsov" <rukletsov@gmail.com>,
 "Bernd Mathiske" <bernd@mesosphere.io>
Cc: "mesos" <reviews@mesos.apache.org>, "Guangya Liu" <gyliu513@gmail.com>,
 "Joerg Schad" <joerg@mesosphere.io>
Date: Wed, 26 Aug 2015 06:30:36 -0000
Message-ID: <20150826063036.13584.42764@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Guangya Liu" <noreply@reviews.apache.org>
References: <20150825055119.13584.56405@reviews.apache.org>
In-Reply-To: <20150825055119.13584.56405@reviews.apache.org>
Reply-To: "Guangya Liu" <gyliu513@gmail.com>

--===============1195817199427169824==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On Aug. 25, 2015, 5:51 a.m., Guangya Liu wrote:
> > src/Makefile.am, line 182
> > <https://reviews.apache.org/r/36908/diff/4/?file=1032680#file1032680line182>
> >
> >     It is better consider the alpha order of those files, we can add quota related files under module related files.
> 
> Alexander Rukletsov wrote:
>     Could you please elaborate? I'm not sure I follow.
> 
> Guangya Liu wrote:
>     I mean the file order in Makefile.am should follow alpha order as other part in this file.
>     
>     My propose is that you only need to re-order the file list here as following:
>     
>     module/module.pb.cc                         \
>       ../include/mesos/module/module.pb.h                   \
>     master/quota.pb.cc                          \
>       ../include/mesos/master/quota.pb.h                    \
>     
>     Just adjust the order should works.
> 
> Alexander Rukletsov wrote:
>     I see. We also include folder into lexicographic sorting, therefore `module > master` and hence all `master/**` go before `module/**`. Does it make sense?
> 
> Guangya Liu wrote:
>     Exactly, this can make the code more readable. I found that both Mesos and OpenStack projects are following such style ;-)
> 
> Alexander Rukletsov wrote:
>     Not sure I follow. Your suggestion above says to put `module/**` before `master/**`. Could you please elaborate what variant is more readable?

My bad,you are right Alex, the current order works.


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36908/#review96299
-----------------------------------------------------------


On Aug. 5, 2015, 2:03 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36908/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2015, 2:03 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3164
>     https://issues.apache.org/jira/browse/MESOS-3164
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added QuotaInfo Protobuf.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/quota.hpp PRE-CREATION 
>   include/mesos/master/quota.proto PRE-CREATION 
>   src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec 
> 
> Diff: https://reviews.apache.org/r/36908/diff/
> 
> 
> Testing
> -------
> 
> make distcheck
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


--===============1195817199427169824==--