Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8C66618C20 for ; Tue, 25 Aug 2015 02:01:26 +0000 (UTC) Received: (qmail 95225 invoked by uid 500); 25 Aug 2015 02:01:26 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 95199 invoked by uid 500); 25 Aug 2015 02:01:26 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 95179 invoked by uid 99); 25 Aug 2015 02:01:26 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Aug 2015 02:01:26 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 724B6269EC2; Tue, 25 Aug 2015 02:01:25 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6991660782568513271==" MIME-Version: 1.0 Subject: Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover From: "Guangya Liu" To: "Vinod Kone" Cc: "Guangya Liu" , "Aditi Dixit" , "mesos" Date: Tue, 25 Aug 2015 02:01:25 -0000 Message-ID: <20150825020125.13584.72432@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Guangya Liu" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/37500/ X-Sender: "Guangya Liu" References: <20150815080321.30461.29489@reviews.apache.org> In-Reply-To: <20150815080321.30461.29489@reviews.apache.org> Reply-To: "Guangya Liu" X-ReviewRequest-Repository: mesos --===============6991660782568513271== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37500/#review96272 ----------------------------------------------------------- src/messages/messages.proto (line 350) It is better to add some comments here. i.e. This message is sent to the slave to update framework user info for a slave. src/slave/slave.cpp (line 2173) Update the indent here - Guangya Liu On Aug. 15, 2015, 8:03 a.m., Aditi Dixit wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37500/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2015, 8:03 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-3240 > https://issues.apache.org/jira/browse/MESOS-3240 > > > Repository: mesos > > > Description > ------- > > Added user to master's state, slave's state (not exposed) and updated user in all slaves that have the registered framework. Added the test too. > > > Diffs > ----- > > src/master/http.cpp 4dcbc0f3e22f6bdb049da41c950bfc2fbfb89ffa > src/master/master.hpp b288b8a7ad84e49b3ca43966a4d20a64985aa98e > src/master/master.cpp 0330f94ad6fe6ac23061e5f45612133747b39a80 > src/messages/messages.proto 8977d8e0f3b16003128b6b9cab556a7b224f083c > src/slave/slave.hpp 41d09497be313819a9c78361b8595f6f26dc8460 > src/slave/slave.cpp 9061e671bea2d52e8c009e92b3d0a4473dca0ad9 > src/tests/master_tests.cpp 0c8e8be2965de3613761515db8a31d72bad97332 > > Diff: https://reviews.apache.org/r/37500/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Aditi Dixit > > --===============6991660782568513271==--