Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C377718044 for ; Wed, 19 Aug 2015 01:20:04 +0000 (UTC) Received: (qmail 34023 invoked by uid 500); 19 Aug 2015 01:19:59 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 34005 invoked by uid 500); 19 Aug 2015 01:19:59 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 33983 invoked by uid 99); 19 Aug 2015 01:19:59 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Aug 2015 01:19:59 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 26327D5335; Wed, 19 Aug 2015 01:19:59 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2586583259491367720==" MIME-Version: 1.0 Subject: Re: Review Request 37177: Maintenance Primitives: Added inverse offers. From: "Guangya Liu" To: "Artem Harutyunyan" , "Benjamin Hindman" , "Joseph Wu" Cc: "Joris Van Remoortere" , "Guangya Liu" , "mesos" Date: Wed, 19 Aug 2015 01:19:59 -0000 Message-ID: <20150819011959.1534.42191@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Guangya Liu" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/37177/ X-Sender: "Guangya Liu" References: <20150818185751.1534.57895@reviews.apache.org> In-Reply-To: <20150818185751.1534.57895@reviews.apache.org> Reply-To: "Guangya Liu" X-ReviewRequest-Repository: mesos --===============2586583259491367720== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37177/#review95805 ----------------------------------------------------------- include/mesos/maintenance/maintenance.hpp (line 38) Remove this blank space. The commit should not be permitted if there are blank space in code. - Guangya Liu On 八月 18, 2015, 6:57 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37177/ > ----------------------------------------------------------- > > (Updated 八月 18, 2015, 6:57 p.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu. > > > Bugs: MESOS-1474 > https://issues.apache.org/jira/browse/MESOS-1474 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/maintenance/maintenance.hpp PRE-CREATION > include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a > src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659 > src/master/allocator/mesos/hierarchical.hpp e278139f856888d6c6f538f7c0f664087e97f629 > src/master/master.hpp 0432842d77beba024c7895291ca410964bae96be > src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf > src/tests/hierarchical_allocator_tests.cpp 9748ca0b38888fee25dcec51c64d8ba84dbd4aaf > src/tests/master_allocator_tests.cpp 89331965553505f6b7eebf39ad27d943df816a24 > src/tests/mesos.hpp 64987f0cc1632eb8b0c2cccd8446a5324127910c > src/tests/reservation_tests.cpp aeee36752573e3f401d3dca7d2d69c90d0e8bd6b > src/tests/resource_offers_tests.cpp 882a9ff4d09aace486182828bf43b643b0d0c519 > src/tests/slave_recovery_tests.cpp e1392a2235ff51dac7a3cb7cd3e8edf8406864fc > > Diff: https://reviews.apache.org/r/37177/diff/ > > > Testing > ------- > > > Thanks, > > Joris Van Remoortere > > --===============2586583259491367720==--