Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4908618CF7 for ; Mon, 17 Aug 2015 20:49:11 +0000 (UTC) Received: (qmail 92766 invoked by uid 500); 17 Aug 2015 20:49:08 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 92743 invoked by uid 500); 17 Aug 2015 20:49:08 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 92680 invoked by uid 99); 17 Aug 2015 20:49:07 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Aug 2015 20:49:07 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 010E1DE7C7; Mon, 17 Aug 2015 20:49:05 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5220505977782704676==" MIME-Version: 1.0 Subject: Re: Review Request 37426: MESOS-3251 : Fixing "host" field of request header. From: "Timothy Chen" To: "Anand Mazumdar" , "Timothy Chen" Cc: "Jojy Varghese" , "mesos" Date: Mon, 17 Aug 2015 20:49:04 -0000 Message-ID: <20150817204904.23957.91454@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Timothy Chen" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/37426/ X-Sender: "Timothy Chen" References: <20150813004622.1374.46855@reviews.apache.org> In-Reply-To: <20150813004622.1374.46855@reviews.apache.org> Reply-To: "Timothy Chen" X-ReviewRequest-Repository: mesos --===============5220505977782704676== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37426/#review95632 ----------------------------------------------------------- 3rdparty/libprocess/src/http.cpp (line 798) Let's add the port to make sure we're adhering to the HTTP 1.1 standard - Timothy Chen On Aug. 13, 2015, 12:46 a.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37426/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2015, 12:46 a.m.) > > > Review request for mesos, Anand Mazumdar and Timothy Chen. > > > Bugs: MESOS-3251 > https://issues.apache.org/jira/browse/MESOS-3251 > > > Repository: mesos > > > Description > ------- > > Currently libprocess http API sets the "Host" header field from the peer socket > address (IP:port). The problem is that socket address might not be right HTTP > server and might be just a proxy. > Changed the logic to look for http server URL's domain first to populate the > "Host" field. > > > Diffs > ----- > > 3rdparty/libprocess/src/http.cpp 4dcbd74b894b483c4d166c23fac55ac8dba75166 > > Diff: https://reviews.apache.org/r/37426/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jojy Varghese > > --===============5220505977782704676==--