Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@mesos.apache.org
Content-Type: multipart/alternative;
 boundary="===============8470564807526890745=="
MIME-Version: 1.0
Subject: Re: Review Request 36819: Use setup.py in python cli package.
From: "haosdent huang" <haosdent@gmail.com>
To: "Benjamin Hindman" <benh@berkeley.edu>,
 "Bernd Mathiske" <bernd@mesosphere.io>,
 "Marco Massenzio" <marco@mesosphere.io>
Cc: "mesos" <reviews@mesos.apache.org>, "haosdent huang" <haosdent@gmail.com>,
 "Alexander Rojas" <alexander@mesosphere.io>
Date: Thu, 13 Aug 2015 02:11:40 -0000
Message-ID: <20150813021140.1374.20987@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "haosdent huang" <noreply@reviews.apache.org>
References: <20150812164759.1375.85479@reviews.apache.org>
In-Reply-To: <20150812164759.1375.85479@reviews.apache.org>
Reply-To: "haosdent huang" <haosdent@gmail.com>

--===============8470564807526890745==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On Aug. 12, 2015, 4:47 p.m., Alexander Rojas wrote:
> > src/cli/python/mesos/__init__.py, line 1
> > <https://reviews.apache.org/r/36819/diff/6/?file=1034329#file1034329line1>
> >
> >     Why was the shebang line removed?

The origin file is __init__.py. __init__.py need have shebang line. But this file become from __init__.py to setup.py. Other setup.py file also don't have shebang.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36819/#review95112
-----------------------------------------------------------


On Aug. 7, 2015, 3:08 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36819/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2015, 3:08 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Marco Massenzio.
> 
> 
> Bugs: MESOS-3149
>     https://issues.apache.org/jira/browse/MESOS-3149
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Use setup.py in python cli package.
> 
> 
> Diffs
> -----
> 
>   Makefile.am f8e958d376efa55ace7c5727a31b8e747403641e 
>   bin/mesos.sh.in 5cbeac4330a9f45fc6d54b8c2d383f48e4098f95 
>   configure.ac 0794279dd2e23b5b593e7e388bd6d04e17c746a6 
>   src/Makefile.am 35ebbbd0bd9c9dd059c02ce3dc22c780b929be81 
>   src/cli/python/mesos/__init__.py 028b0d27fb193bac96f2a6a3201ee4cc8fd369ef 
>   src/cli/python/mesos/cli.py  
>   src/cli/python/mesos/futures.py  
>   src/cli/python/mesos/http.py  
>   src/python/cli/src/mesos/__init__.py PRE-CREATION 
>   src/python/interface/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 
>   src/python/native/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 
>   src/python/protocol/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311 
> 
> Diff: https://reviews.apache.org/r/36819/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> # Test in CentOS 6.6, OS X 10.10, Ubuntu 14.04
> ## test steps:
> 1. sudo make install
> 2. export PYTHONPATH
> 3. python -c 'import mesos; from mesos import cli, http, futures'
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


--===============8470564807526890745==--