Return-Path: 
 <reviews-return-7237-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org>
X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org
Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 882D818E65
	for <apmail-mesos-reviews-archive@minotaur.apache.org>;
 Wed, 12 Aug 2015 21:30:08 +0000 (UTC)
Received: (qmail 288 invoked by uid 500); 12 Aug 2015 21:29:34 -0000
Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org
Received: (qmail 263 invoked by uid 500); 12 Aug 2015 21:29:34 -0000
Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:reviews-help@mesos.apache.org>
List-Unsubscribe: <mailto:reviews-unsubscribe@mesos.apache.org>
List-Post: <mailto:reviews@mesos.apache.org>
List-Id: <reviews.mesos.apache.org>
Reply-To: reviews@mesos.apache.org
Delivered-To: mailing list reviews@mesos.apache.org
Received: (qmail 251 invoked by uid 99); 12 Aug 2015 21:29:34 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Aug 2015 21:29:34 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id 842E5DC545;
	Wed, 12 Aug 2015 21:29:31 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============1706208103866124959=="
MIME-Version: 1.0
Subject: Re: Review Request 37268: Style checker checking for { on newline
From: =?utf-8?q?Jos=C3=A9_Guilherme_Vanz?= <guilherme.sft@gmail.com>
To: =?utf-8?q?Jos=C3=A9_Guilherme_Vanz?= <guilherme.sft@gmail.com>,
 Mesos ReviewBot <reviews@mesos.apache.org>, mesos <reviews@mesos.apache.org>
Date: Wed, 12 Aug 2015 21:29:31 -0000
Message-ID: <20150812212931.1374.35703@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org/
Auto-Submitted: auto-generated
Sender: =?utf-8?q?Jos=C3=A9_Guilherme_Vanz?= <noreply@reviews.apache.org>
X-ReviewGroup: mesos
X-Auto-Response-Suppress: DR, RN, OOF, AutoReply
X-ReviewRequest-URL: https://reviews.apache.org/r/37268/
X-Sender: 
 =?utf-8?q?=22Jos=C3=A9_Guilherme_Vanz=22_=3Cnoreply=40reviews=2Eapache=2E?=
 =?utf-8?q?org=3E?=
References: <20150809232816.1375.12385@reviews.apache.org>
In-Reply-To: <20150809232816.1375.12385@reviews.apache.org>
Reply-To: =?utf-8?q?Jos=C3=A9_Guilherme_Vanz?= <guilherme.sft@gmail.com>
X-ReviewRequest-Repository: mesos

--===============1706208103866124959==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit



> On Aug. 9, 2015, 11:28 p.m., Mesos ReviewBot wrote:
> > Bad patch!
> > 
> > Reviews applied: [37266]
> > 
> > Failed command: ./support/apply-review.sh -n -r 37266
> > 
> > Error:
> >  2015-08-09 23:28:17 URL:https://reviews.apache.org/r/37266/diff/raw/ [8119/8119] -> "37266.patch" [1]
> > Traceback (most recent call last):
> >   File "./support/jsonurl.py", line 25, in <module>
> >     print data
> > UnicodeEncodeError: 'ascii' codec can't encode character u'\xe9' in position 3: ordinal not in range(128)
> > Successfully applied: Style checker checking for { on newline
> > 
> > As requested in the issue MESOS-2578 the style checker now
> > verifies "{" on newline for class and methods declarations.
> > 
> > This commit contains the files changed in the mesos project
> > 
> > 
> > Review: https://reviews.apache.org/r/37266
> > fatal: empty ident name (for <guilherme.sft@gmail.com>) not allowed
> > Failed to commit patch

Solved. There is a issue with description with "


- José Guilherme


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37268/#review94684
-----------------------------------------------------------


On Aug. 12, 2015, 1:15 a.m., José Guilherme Vanz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37268/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2015, 1:15 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-2578
>     https://issues.apache.org/jira/browse/MESOS-2578
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> As requested in the issue MESOS-2578 the style checker now
> verifies { on newline for class and methods declarations.
> 
> This commit contains the files changed in the stout project
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp 30baa65837621a277cf9d1042a751bfe18004b05 
> 
> Diff: https://reviews.apache.org/r/37268/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> José Guilherme Vanz
> 
>


--===============1706208103866124959==--