Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2EDB9181DD for ; Sat, 8 Aug 2015 15:35:18 +0000 (UTC) Received: (qmail 27889 invoked by uid 500); 8 Aug 2015 15:35:11 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 27864 invoked by uid 500); 8 Aug 2015 15:35:11 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 27849 invoked by uid 99); 8 Aug 2015 15:35:11 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 08 Aug 2015 15:35:11 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 9F74ED773B; Sat, 8 Aug 2015 15:35:09 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8849931173133310126==" MIME-Version: 1.0 Subject: Re: Review Request 37244: Fixed scheduler message metrics to work with scheduler Calls. From: "Guangya Liu" To: "Anand Mazumdar" , "Ben Mahler" Cc: "Guangya Liu" , "mesos" , "Vinod Kone" Date: Sat, 08 Aug 2015 15:35:09 -0000 Message-ID: <20150808153509.11539.48811@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Guangya Liu" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/37244/ X-Sender: "Guangya Liu" References: <20150808153206.11539.40536@reviews.apache.org> In-Reply-To: <20150808153206.11539.40536@reviews.apache.org> Reply-To: "Guangya Liu" X-ReviewRequest-Repository: mesos --===============8849931173133310126== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37244/#review94632 ----------------------------------------------------------- Ship it! Thanks for the update - Guangya Liu On 八月 8, 2015, 3:32 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37244/ > ----------------------------------------------------------- > > (Updated 八月 8, 2015, 3:32 p.m.) > > > Review request for mesos, Anand Mazumdar and Ben Mahler. > > > Bugs: MESOS-3195 > https://issues.apache.org/jira/browse/MESOS-3195 > > > Repository: mesos > > > Description > ------- > > The one difference between the old code and this code is that metrics are not updated if we drop the call (e.g., framework is unknown or wrong framework). But I think that's reasonable. > > > Diffs > ----- > > src/master/master.cpp 0330f94ad6fe6ac23061e5f45612133747b39a80 > src/master/metrics.hpp 5e96a5f71d042592524fec2151f37de28e3008ea > src/tests/master_tests.cpp 0c8e8be2965de3613761515db8a31d72bad97332 > > Diff: https://reviews.apache.org/r/37244/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > > --===============8849931173133310126==--