Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4D63E18E77 for ; Mon, 3 Aug 2015 18:30:48 +0000 (UTC) Received: (qmail 42930 invoked by uid 500); 3 Aug 2015 18:30:48 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 42909 invoked by uid 500); 3 Aug 2015 18:30:48 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 42894 invoked by uid 99); 3 Aug 2015 18:30:47 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Aug 2015 18:30:47 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 6F910D8A96; Mon, 3 Aug 2015 18:30:46 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1915394563929406207==" MIME-Version: 1.0 Subject: Re: Review Request 36404: Added support for peek() to process::io From: "Artem Harutyunyan" To: "Joris Van Remoortere" , "Joseph Wu" Cc: "Artem Harutyunyan" , "mesos" Date: Mon, 03 Aug 2015 18:30:46 -0000 Message-ID: <20150803183046.4205.6438@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Artem Harutyunyan" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/36404/ X-Sender: "Artem Harutyunyan" References: <20150803174402.4205.76374@reviews.apache.org> In-Reply-To: <20150803174402.4205.76374@reviews.apache.org> Reply-To: "Artem Harutyunyan" X-ReviewRequest-Repository: mesos --===============1915394563929406207== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36404/ ----------------------------------------------------------- (Updated Aug. 3, 2015, 11:30 a.m.) Review request for mesos, Joris Van Remoortere and Joseph Wu. Changes ------- Missing commas. Repository: mesos Description ------- JIRA: https://issues.apache.org/jira/browse/MESOS-2964 Diffs (updated) ----- 3rdparty/libprocess/include/process/io.hpp 975923f40f82357f31b89428f24d01df6a8ac9fc 3rdparty/libprocess/src/io.cpp 4a6e18a17012994d358099ad32d4c282fea3b0b1 3rdparty/libprocess/src/tests/io_tests.cpp c642b3333ab9e2845668767ad237985cb9ce1109 Diff: https://reviews.apache.org/r/36404/diff/ Testing ------- - Added a test case for process::io::peek - make check Thanks, Artem Harutyunyan --===============1915394563929406207==--