mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Neil Conway" <neil.con...@gmail.com>
Subject Re: Review Request 37945: change const pass-by-value to const reference in stout
Date Mon, 31 Aug 2015 17:28:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37945/#review97088
-----------------------------------------------------------



3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp (line 82)
<https://reviews.apache.org/r/37945/#comment152830>

    This comment seems to contradict the changes made by this patch -- the comment seems correct
(http://stackoverflow.com/a/222314).


- Neil Conway


On Aug. 31, 2015, 10:46 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37945/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2015, 10:46 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-1805
>     https://issues.apache.org/jira/browse/MESOS-1805
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> change const pass-by-value to const reference in stout
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp 1cf6dd18aa163688d6c8f3a6d33eacad3918015d

>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/shell.hpp 68fc1fd179ee51fc5de0452c0f2ea3d354e0567f

>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/shell.hpp 01e59de466496dec9367ad6f48538327f53a7e18

> 
> Diff: https://reviews.apache.org/r/37945/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message