mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "haosdent huang" <haosd...@gmail.com>
Subject Re: Review Request 37505: Fix broken health check in docker executor.
Date Sun, 30 Aug 2015 07:33:30 GMT


> On Aug. 26, 2015, 4:46 p.m., Timothy Chen wrote:
> > src/docker/docker.hpp, line 48
> > <https://reviews.apache.org/r/37505/diff/3/?file=1048044#file1048044line48>
> >
> >     Why we need a default version?

I try to reduce change too much exist code before, but now we don't need this default version.
:-)


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37505/#review96545
-----------------------------------------------------------


On Aug. 30, 2015, 7:32 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37505/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2015, 7:32 a.m.)
> 
> 
> Review request for mesos, Adam B and Timothy Chen.
> 
> 
> Bugs: MESOS-3136
>     https://issues.apache.org/jira/browse/MESOS-3136
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix broken health check in docker executor.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.hpp 6086710fff32a25e46197a69ae1063074317221b 
>   src/docker/docker.cpp 12dc0505c9ec4bd380e817d44da2c4e8d1b0d5f5 
>   src/docker/executor.cpp 256d53d59d5cda63bbeb8c987ce0019e24b9fb77 
>   src/slave/containerizer/docker.cpp a17e4f21e7f5a1dfd47699ec84c7a48fd82294ad 
>   src/tests/health_check_tests.cpp 157a56aa06677d8b7a2cef53b29ed05cb4b5d8ea 
> 
> Diff: https://reviews.apache.org/r/37505/diff/
> 
> 
> Testing
> -------
> 
> # Add two new test cases, HealthCheckTest.ROOT_DOCKER_DockerHealthyTask and HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange
> # Docker health check command is run through "docker exec"
> sudo ./bin/mesos-tests.sh --gtest_filter="HealthCheckTest.ROOT_DOCKER_DockerHealthyTask"
--verbose
> sudo ./bin/mesos-tests.sh --gtest_filter="HealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange"
--verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message