mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aditi Dixit" <aditi9di...@gmail.com>
Subject Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover
Date Tue, 25 Aug 2015 19:45:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37500/
-----------------------------------------------------------

(Updated Aug. 25, 2015, 7:45 p.m.)


Review request for mesos and Vinod Kone.


Changes
-------

1. Shifted the slave updation of FrameworkInfo.user to use the existing UpdateFrameworkMessage
instead of creating a new message. 
2. Also added test for checking slave updation of FrameworkInfo.user in case of framework
reregistration.
3. Added user checking in UpdateFrameworkInfoOnSchedulerFailover.


Bugs: MESOS-3240
    https://issues.apache.org/jira/browse/MESOS-3240


Repository: mesos


Description
-------

Added user to master's state, slave's state (not exposed) and updated user in all slaves that
have the registered framework. Added the test too.


Diffs (updated)
-----

  src/master/http.cpp 4dcbc0f3e22f6bdb049da41c950bfc2fbfb89ffa 
  src/master/master.hpp b288b8a7ad84e49b3ca43966a4d20a64985aa98e 
  src/master/master.cpp 0330f94ad6fe6ac23061e5f45612133747b39a80 
  src/messages/messages.proto 8977d8e0f3b16003128b6b9cab556a7b224f083c 
  src/slave/slave.hpp 41d09497be313819a9c78361b8595f6f26dc8460 
  src/slave/slave.cpp 9061e671bea2d52e8c009e92b3d0a4473dca0ad9 
  src/tests/fault_tolerance_tests.cpp c63599ad36d883d25a23f5bab1929c4e2dad4960 
  src/tests/master_tests.cpp 0c8e8be2965de3613761515db8a31d72bad97332 
  src/tests/slave_recovery_tests.cpp e1392a2235ff51dac7a3cb7cd3e8edf8406864fc 
  src/tests/slave_tests.cpp cb5a01ed771e66d75091ca33523dbe673e16a86e 

Diff: https://reviews.apache.org/r/37500/diff/


Testing
-------

make check


Thanks,

Aditi Dixit


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message