mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 37500: Update the FrameworkInfo.user on scheduler failover
Date Mon, 24 Aug 2015 23:56:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37500/#review96240
-----------------------------------------------------------


This review is a bit hard to follow because it's doing multiple things. I would recommend
you to split this into multiple reviews

#1) Expose framework user in state.json
#2) Update framework user on re-registration (need a test for this!)


src/master/master.hpp 
<https://reviews.apache.org/r/37500/#comment151577>

    So you are not updating the 'info.user' at all? How come?



src/master/master.cpp (lines 1879 - 1886)
<https://reviews.apache.org/r/37500/#comment151579>

    Per the design doc, we don't need a new message. You should be able to augment the existing
UpdateFrameworkMessage to include FrameworkInfo. 
    
    Any particular reason you introduced a new one?



src/slave/slave.cpp (lines 446 - 450)
<https://reviews.apache.org/r/37500/#comment151581>

    no need for this if you just use the existing handler for update framework message.



src/tests/master_tests.cpp (line 2973)
<https://reviews.apache.org/r/37500/#comment151582>

    s/FrameworkWebUIUrlCapabilitiesAndUser/FrameworkState/


- Vinod Kone


On Aug. 15, 2015, 8:03 a.m., Aditi Dixit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37500/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2015, 8:03 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3240
>     https://issues.apache.org/jira/browse/MESOS-3240
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added user to master's state, slave's state (not exposed) and updated user in all slaves
that have the registered framework. Added the test too.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 4dcbc0f3e22f6bdb049da41c950bfc2fbfb89ffa 
>   src/master/master.hpp b288b8a7ad84e49b3ca43966a4d20a64985aa98e 
>   src/master/master.cpp 0330f94ad6fe6ac23061e5f45612133747b39a80 
>   src/messages/messages.proto 8977d8e0f3b16003128b6b9cab556a7b224f083c 
>   src/slave/slave.hpp 41d09497be313819a9c78361b8595f6f26dc8460 
>   src/slave/slave.cpp 9061e671bea2d52e8c009e92b3d0a4473dca0ad9 
>   src/tests/master_tests.cpp 0c8e8be2965de3613761515db8a31d72bad97332 
> 
> Diff: https://reviews.apache.org/r/37500/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Aditi Dixit
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message