mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Chen" <tnac...@apache.org>
Subject Re: Review Request 37426: MESOS-3251 : Fixing "host" field of request header.
Date Mon, 17 Aug 2015 20:49:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37426/#review95632
-----------------------------------------------------------



3rdparty/libprocess/src/http.cpp (line 798)
<https://reviews.apache.org/r/37426/#comment150741>

    Let's add the port to make sure we're adhering to the HTTP 1.1 standard


- Timothy Chen


On Aug. 13, 2015, 12:46 a.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37426/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2015, 12:46 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Timothy Chen.
> 
> 
> Bugs: MESOS-3251
>     https://issues.apache.org/jira/browse/MESOS-3251
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Currently libprocess http API sets the "Host" header field from the peer socket
> address (IP:port). The problem is that socket address might not be right HTTP
> server and might be just a proxy.
>   Changed the logic to look for http server URL's domain first to populate the
> "Host" field.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/http.cpp 4dcbd74b894b483c4d166c23fac55ac8dba75166 
> 
> Diff: https://reviews.apache.org/r/37426/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message